Fix #2450#2475
Closed
ImmanuelHaffner wants to merge 1 commit intoWebAssembly:masterfrom
ImmanuelHaffner:libbinaryen-monolithic
Closed
Fix #2450#2475ImmanuelHaffner wants to merge 1 commit intoWebAssembly:masterfrom ImmanuelHaffner:libbinaryen-monolithic
ImmanuelHaffner wants to merge 1 commit intoWebAssembly:masterfrom
ImmanuelHaffner:libbinaryen-monolithic
Conversation
using the `$<TARGET_OBJECTS:objlib>` syntax. Use this variable when adding `libbinaryen` as static or shared library. Additionally, use the variable with the object files to simplify the `TARGET_LINK_LIBRARIES` commands: add the object libraries to the sources of executables and drop the use of our libraries in `TARGET_LINK_LIBRARIES`. (Object libraries cannot be linked but must be used as sources. See https://cmake.org/pipermail/cmake/2018-June/067721.html)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect all object files from the object libraries in a CMake variable using the
$<TARGET_OBJECTS:objlib>syntax. Use this variable whenadding
libbinaryenas static or shared library. Additionally, use thevariable with the object files to simplify the
TARGET_LINK_LIBRARIEScommands: add the object libraries to the sources of executables and
drop the use of our libraries in
TARGET_LINK_LIBRARIES. (Objectlibraries cannot be linked but must be used as sources. See
https://cmake.org/pipermail/cmake/2018-June/067721.html)
This PR is a follow up on #2472